From 56bf151b4fd091360246b2cfe230997e4082b0bc Mon Sep 17 00:00:00 2001 From: David Li Date: Wed, 13 Jan 2016 09:42:18 -0700 Subject: Start working on updating global data structures --- src/shareable_cache.rs | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) (limited to 'src/shareable_cache.rs') diff --git a/src/shareable_cache.rs b/src/shareable_cache.rs index 9e0725a..6ee17c3 100644 --- a/src/shareable_cache.rs +++ b/src/shareable_cache.rs @@ -52,7 +52,7 @@ impl<'a> ShareableCache<'a> { if cache.borrow().is_address_accessible(address) { // Depends on invariant: write_word completes instantly // when the address is accessible (in-cache) - cache.borrow_mut().write_word(address, value); + let _ = cache.borrow_mut().write_word(address, value); } } } @@ -76,6 +76,11 @@ impl<'a> MemoryInterface for ShareableCache<'a> { } fn read_word(&mut self, address: isa::Address) -> Result { + // TODO: disallow access to high or low memory unless + // secondary cache is enabled. Remember: addresses are already + // translated + + // TODO: is CacheRacer physically or virtually addressed? if self.secondary_enabled { let (primary_accessible, secondary_accessible) = self.address_accessible(address); -- cgit v1.2.3